Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12596 fix RasterSource does not end Tile transition #12597

Merged
merged 2 commits into from
Aug 5, 2021
Merged

#12596 fix RasterSource does not end Tile transition #12597

merged 2 commits into from
Aug 5, 2021

Conversation

mwerlitz
Copy link
Contributor

@mwerlitz mwerlitz commented Aug 4, 2021 •
edited by ahocevar
Loading

fixes #12596

@mwerlitz mwerlitz mentioned this pull request Aug 4, 2021
Closed
@mwerlitz
Copy link
Contributor Author

mwerlitz commented Aug 4, 2021

Maybe it's also possible to replace line RasterSource:780 this.changed(); with requestAnimationFrame(this.changed.bind(this));

ahocevar
ahocevar reviewed Aug 5, 2021
View reviewed changes
src/ol/source/Raster.js Outdated Show resolved Hide resolved
ahocevar
ahocevar reviewed Aug 5, 2021
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix makes sense. Thanks!

I added one suggestion for a whitespace fix to make the CI happy. Please commit that suggestion, then we can merge this.

@mwerlitz @ahocevar
fix whitespace error
aea11b7 
Co-authored-by: Andreas Hocevar <andreas.hocevar@gmail.com>
@mwerlitz
Copy link
Contributor Author

mwerlitz commented Aug 5, 2021

Ops, sorry for the whitespace problem. IDE setup was not complete yet.

@ahocevar
Copy link
Member

ahocevar commented Aug 5, 2021

Thanks, @mwerlitz!

@ahocevar ahocevar merged commit f8ac74f into openlayers:main Aug 5, 2021
@perliedman perliedman mentioned this pull request Oct 10, 2021
Closed
@tschaub tschaub mentioned this pull request Oct 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahocevar ahocevar ahocevar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RasterSource does not end Tile transition
2 participants
@mwerlitz @ahocevar