Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set popover position in geographic example #13030

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Nov 20, 2021

Fixes #13029

Popover is only initialized once, calling popover again does not change the content unless the popover was disposed.
Not necessary for this example as there is only one feature, but feels like a good idea to have it anyways.

@github-actions
Copy link

📦 Preview the examples and docs from this branch here: https://deploy-preview-13030--ol-site.netlify.app/.

@jipexu
Copy link
Contributor

jipexu commented Nov 20, 2021

Thanks
what do you think for the longitude values ?

@MoonE
Copy link
Contributor Author

MoonE commented Nov 20, 2021

I think it makes sense to not keep the center longitude to the range of [ -180, 180 ).
The example shows how to work with geographic coordinates in OpenLayers and coordinates won't wrap automatically, so I think it makes sense to display it this way.

@jipexu
Copy link
Contributor

jipexu commented Nov 21, 2021

Ok but for me it is not comprehensible and quite confusing that a longitude can display such results in a geographic application... A visitor playing with the example will say at first glance that something is wrong ... It is not the correctness or logic of the code that causes me the problem but what is shown in this example...

@MoonE
Copy link
Contributor Author

MoonE commented Nov 21, 2021

I understand you concerns from a user's point of view, but these are the values provided by OpenLayers for developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geographic example - strange longitude
3 participants