Render is only complete when no tiles are queued #13095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
rendercomplete-tiles
branch
from
7139df8
to
66e0a95
Compare
|
📦 Preview the examples and docs from this branch here: https://deploy-preview-13095--ol-site.netlify.app/. |
|
This does not work. The Saving the tile queue state during frameState.hasTilesQueued = this.tileQueue_.getTilesLoading() > 0 || !this.tileQueue_.isEmpty(); |
ahocevar
force-pushed
the
rendercomplete-tiles
branch
from
66e0a95
to
c59047c
Compare
|
@M393 Thanks for the feedback and suggestion. I updated the pull request along these lines. Can you please test again? |
|
Unfortunately I was unable to create a regression test for this, so I'm marking this ready for review. |
tschaub
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13086.
@M393, can you please confirm that this fixes the issue? If so, I'll try to add a regression test.