-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ecoregions data #13177
Use ecoregions data #13177
Conversation
📦 Preview the examples and docs from this branch here: https://deploy-preview-13177--ol-site.netlify.app/. |
In a map export there is no reason (apart from a very un-obvious assertion if you don't set a |
Good point. I adjusted the example to do this.
I don't agree with this part. I think it is unfortunate that our examples tend to get more complex and uglier over time, as people add new functionality or fix issues and tack features on to existing examples as a way to demonstrate the change to themselves. While the changes likely make sense to the author, I don't think this makes the examples more useful. I can imagine it would be useful to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this huge effort, @tschaub!
This branch replaces the use of the current countries dataset with data from the RESOLVE Ecoregions 2017 dataset.
See the updated examples. I'm curious if people think these load or render too slowly.
The new https://github.com/openlayers/data repo is a place where we can host data for our examples. Yes, data in git is not fun, but these are the benefits:
Fixes #12940
Closes #12941
Closes #12942