Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use event.key instead of event.charCode #14492

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Use event.key instead of event.charCode #14492

merged 2 commits into from
Feb 8, 2023

Conversation

WebKieth
Copy link

@WebKieth WebKieth commented Feb 7, 2023

Thanks for approving to change unstable code of interaction. Build Checked, feel free to review =)

@WebKieth WebKieth changed the title moved deprecated charcode prop Moved deprecated charcode prop Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

📦 Preview the website for this branch here: https://deploy-preview-14492--ol-site.netlify.app/.

ahocevar
ahocevar requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WebKieth, can you please run npm run lint --fix to fix the problems the linter identified?

@tschaub tschaub changed the title Moved deprecated charcode prop Use event.key instead of event.charCode Feb 8, 2023
@tschaub
Copy link
Member

tschaub commented Feb 8, 2023

Thanks, @WebKieth

@tschaub tschaub merged commit 4cd6ecf into openlayers:main Feb 8, 2023
@ahocevar ahocevar mentioned this pull request Feb 8, 2023
Closed
@mike-000 mike-000 mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaub tschaub tschaub approved these changes

@ahocevar ahocevar ahocevar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WebKieth @tschaub @ahocevar