Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated KeyboardEvent properties #14598

Merged
merged 4 commits into from Mar 23, 2023
Merged

Update deprecated KeyboardEvent properties #14598

merged 4 commits into from Mar 23, 2023

Conversation

mike-000
Copy link
Contributor

In addition to KeyboardEvent.charCode updated by #14492 MDN https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent#obsolete_properties now lists KeyboardEvent.keyCode and KeyboardEvent.which as deprecated and recommends using KeyboardEvent.key instead.

@github-actions
Copy link

📦 Preview the website for this branch here: https://deploy-preview-14598--ol-site.netlify.app/.

@mike-000 mike-000 marked this pull request as ready for review March 21, 2023 21:19
tschaub
tschaub approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@tschaub tschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mike-000

@tschaub tschaub merged commit b2d5e22 into openlayers:main Mar 23, 2023
8 checks passed
@mike-000 mike-000 deleted the KeyboardEvent branch March 23, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaub tschaub tschaub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mike-000 @tschaub