Apply dashed line hit detection to all geometry types #14938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14938--ol-site.netlify.app/. |
ahocevar
requested changes
Aug 3, 2023
Set the resolution to ensure hit is between dashes
ahocevar
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14936
Previously only LineString geometry was hit detected between dashes. A MultiLineString with similar coordinates would not (although using the previous test for LineString would have not have noticed that as it was hitting the rounded end of a dash).
This applies the same logic to LineString and MultiLineString, plus Polygon, MutiPolygon and Circle geometry outlines, and sets the test resolution and geometry coordinates to match the dash intervals to ensure a meaningful test with hits midway between dashes.
Vector layer hit detection already had this behaviour, so map and vector layer hit detection will now be consistent.