WebGL / only check polygons winding order for RenderFeature #15114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahow
commented
Sep 11, 2023
| ], | ||
| [ | ||
| [40, 41], | ||
| [42, 43], | ||
| [44, 45], | ||
| [46, 47], | ||
| [46, -47], |
There was a problem hiding this comment.
These coordinates have been changed so that the winding orders are correct for the outer and inner rings (before that not much attention had been given to it)
The Feature instances should already come with correctly separated multi- polygons. The RenderFeature instances can contain multipolygons in the form of polygons with several outer rings; to handle this we use the inflateEnds utility which recreates the polygon ends according to the winding order. Added a rendering test to make sure holes correctly render for Feature instances.
jahow
force-pushed
the
fix-webgl-polygon-hole-rendering
branch
from
ba3e02c
to
1361a79
Compare
|
📦 Preview the website for this branch here: https://deploy-preview-15114--ol-site.netlify.app/. |
ahocevar
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantage of #15113 to correctly handle RenderFeatures of type polygon, in case these contain multipolygons with several outer rings.
Polygon holes should now properly render both for Vector and VectorTile sources, i.e. for Feature and RenderFeature instances.
Replaces #15090
Fixes #15089
Fixes #14949