Add change event to Geolocation #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ ol.GeolocationProperty = { | |||
| * // take the projection to use from the map's view | |||
| * geolocation.bindTo('projection', map.getView()); | |||
| * // listen to changes in position | |||
| * geolocation.on('change:position', function(evt) { | |||
| * geolocation.on('change', function(evt) { | |||
| * window.console.log(geolocation.getPosition()); | |||
There was a problem hiding this comment.
This debugging code should probably be removed (I know that it was already present).
There was a problem hiding this comment.
This console.log is actually in the API doc :-)
|
+1 |
elemoine
pushed a commit
that referenced
this pull request
Mar 17, 2014
Add change event to Geolocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Geolocation instances dispatch
changeevents when the geolocation changes.Currently the example in the API doc suggests listening to
change:positionto get notified when the geolocation changes. But speed and accuracy_geometry are not yet up-to-date when this event occurs. This PR fixes this problem by introducing achangeevent dispached when all the geolocation properties have been updated.Please review.