Use constant for CSS class 'ol-unselectable'. #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, please merge. |
marcjansen
added a commit
that referenced
this pull request
Mar 12, 2013
Use constant for CSS class 'ol-unselectable'.
|
Thanks for the review, @twpayne. |
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request suggests replacing the various occurencies of the string
'ol-unselectable'(a CSS class we add to DOM elements) with a constant defined inol.js.Note: Currently the integration tests (which are also running on travis) run into a timeout as an external WMS server seems to be down. See #353.