Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort check-examples target if phantomjs takes too long to run examples. #353

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Mar 12, 2013

Currently a WMS server (http://demo.opengeo.org/geoserver) seems to be down, which results in a neverending integration-test target:

2013-03-12 09:13:12,232 check-examples: phantomjs bin/check-example.js build/gh-pages/unselectable-css-const/examples/wms-single-image.html?mode=raw

We should probably abort phantomjs after a certain amount of time has passed.

@marcjansen
Copy link
Member Author

Fine as a workaround. Actually all external resources might break this target, right?

This is good to be merged, though. Maybe we come up with s.th. more clever in the future. Thanks for tackling this, @twpayne.

@ahocevar
Copy link
Member

I think one of the goals of this build target should be to detect external resources that are down, to give developers a chance to change them to other resources that are up. So I'm not so sure if we really want to be more lenient about errors with external resources. Instead of @twpayne's workaround, I'd rather see us change the examples that rely on resources that are down to ones that are up. Pull request to come.

@elemoine
Copy link
Member

@ahocevar, that makes sense. Thanks.

@twpayne
Copy link
Contributor

twpayne commented Mar 13, 2013

I agree that #360 is a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants