Snap : only listen to change event triggered by the feature #6386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ol.Feature catch change event from its geometry and trigger a change event itself. ol.Feature will also trigger change event when its geometryName has changed
ahocevar
approved these changes
Jan 20, 2017
There was a problem hiding this comment.
Excellent work @tchandelle, and thanks for the additional tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6372
I've replaced both listeners on
change(triggered by the geometry) andchange:geometry(triggered by the feature) by one listener onchange, triggered by the feature. This will catch changes on the geometry coordinates, replacement of geometry and changes on geometry name.