-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use path type instead of ol.tilegrid #7985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type here has to be module:ol/tilegrid/TileGrid~TileGrid
, not module:ol/tilegrid~TileGrid
. I made the same mistake in src/ol/tilecoord.js
, where it should be changed as well.
changed. I've also added a commit that fixes the name for extent Corner Relationship |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please merge.
Thanks for the review |
@@ -129,14 +127,12 @@ function resolutionsFromExtent(extent, opt_maxZoom, opt_tileSize) { | |||
* DEFAULT_MAX_ZOOM). | |||
* @param {number|module:ol/size~Size=} opt_tileSize Tile size (default uses | |||
* DEFAULT_TILE_SIZE). | |||
* @param {module:ol/extent~Extent.Corner=} opt_corner Extent corner (default is | |||
* module:ol/extent~Extent.Corner.BOTTOM_LEFT). | |||
* @param {module:ol/extent/Corner~Corner=} opt_corner Extent corner (default is `'top-left'`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: the comment was wrong, the default value is really 'top-left'
(see createForExtent
function)
See #7947.