Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for ol.Object to have symbolic properties #8006

Conversation

bkuster
Copy link
Contributor

@bkuster bkuster commented Mar 21, 2018

The API of set, get and listen supports Symbol to be a key. Listeners for Symbol properties use Symbol.toString() for explicit property changes.

closes #7757

To be discussed:

  • is the test for support of Object.getOwnPropertySymbols necessary or is this polyfilled?
  • assign only works if Object.assign is a function, not for the provided polyfill (symbols are not part of for-in loops). This was ignored since browsers with Symbol support also have Object.assign (aka all but IE11). Ref: MDN assign and MDN Symbol.
  • missing IE11 support of current builds: with the move to for-in loops, const declaration in IE11 throws an error. See kangax.github.com.

The API of set, get and listen supports Symbol to be
used as a key. Listeners for Symbol properties use Symbol.toString() for explicit property changes.
@stale
Copy link

stale bot commented May 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 22, 2019
@stale stale bot closed this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for symbolic properties
1 participant