Proper vector exports to get vector examples working #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this, and for the fix. Please merge when Travis is happy. |
|
Travis keeps quitting on us, but I see that this will fail due to our strict linting of generated files. @twpayne how about we lift the restriction on line length when linting generated externs/types? |
|
Depends on #821. |
This makes the style-rules.html example work with built lib.
This was previously called getTransformFeatureInfo, which is a method instead of an option. In addition, the generate-exports.py script does not properly export properties whose names appear on a different line than the @Property annotation. This makes the vector-layer.html, kml.html, and gpx.html examples work with the built lib.
|
Rebased after merging #821. Will merge when the build passes. |
tschaub
added a commit
that referenced
this pull request
Jun 26, 2013
Proper vector exports to get vector examples working
afabiani
pushed a commit
to geosolutions-it/openlayers
that referenced
this pull request
May 22, 2017
Add RESTful compatibility support, r=@marcjansen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature information is not properly displayed in the vector-layer.html, kml.html, and gpx.html examples with the built lib. In addition, the style-rules.html example doesn't display the labeled points.