Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ts typing for fullscreen button #8843

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Fix ts typing for fullscreen button #8843

merged 1 commit into from
Oct 23, 2018

Conversation

tonio
Copy link
Member

@tonio tonio commented Oct 23, 2018

No description provided.

fredj
fredj reviewed Oct 23, 2018
View reviewed changes
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about saving the button into a private variable instead of using this.element.firstElementChild?

In the constructor:

/**
 * @private
 * @type {HTMLElement}
 */
this.button_ = document.createElement('button');

@tonio
Copy link
Member Author

tonio commented Oct 23, 2018

Yep, done

fredj
fredj approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@tonio tonio merged commit 1740f02 into openlayers:master Oct 23, 2018
@tonio tonio deleted the ts_fullscreen branch October 23, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonio @fredj