Layer is reponsible for its renderer #8922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgravin
force-pushed
the
layerrenderapi
branch
from
07082f1
to
c2c599a
Compare
fgravin
changed the title
tschaub
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move layer rendering logic from Map renderer to Layer.
Each layer instanciates its own renderer. The layer new
render()method is in charge to manage the rendering of the layer.This aims to add new layer type along with completly different rendering logic (SVG, WebGL, ...).
Start to rework the layer render do have no dependency on the map renderer, that should be removed in the end.
Work in progress, direction to be confirmed.