Add ol.CollectionEvent#getElement #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Quick note: I would have liked to "export" the elem property instead of adding a getter, but I'm not aware of a good way to do that. I considered using the new @dict annotation, but |
|
Thanks for the review @fredj. |
elemoine
pushed a commit
that referenced
this pull request
Aug 28, 2013
Add ol.CollectionEvent#getElement
This was referenced Aug 28, 2013
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ol.Collection objects trigger "add" and "remove" events when element are added to, and removed from, the collection. This is very useful; to be notified when layers are added/removed to/from the map for example. Currently, applications using ol.js can register "add" and "remove" listeners, but they cannot get a reference to the element to which "add" and "remove" events pertain. Quite annoying. This PR adds a getElement method to ol.Collection, and export it.