This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
Centralize layer filter #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +65,13 @@ | |||
| updateCatalogTree(); | |||
| }); | |||
|
|
|||
| scope.map.getLayers().on('remove', function(evt) { | |||
| var layer = evt.elem; | |||
There was a problem hiding this comment.
Isn't "elem" renamed by the compiler? I added getElement for exactly this: openlayers/openlayers#929.
There was a problem hiding this comment.
Good catch! Will be addressed in the dependent #375.
There was a problem hiding this comment.
Well, it's not yet in our ol3 version.
There was a problem hiding this comment.
I know we need to update ol3.
|
I'm closing this as we decided that it's better to keep the filters in the corresponding directives. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #375, this centralises the current layer filter in order to be used elsewhere in the application.
Note: this PR depends on #375 to be merged first.