-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Features: Notes and Annotations #27
Open
aMoniker
wants to merge
28
commits into
internetarchive:master
Choose a base branch
from
aMoniker:notes_and_annotations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crolling while they're open, close on non-colorbox/nav clicks
…tes popup when no notes are present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds two new features to BookReader called Notes and Annotations.
These features were developed as part of a project sponsored by the Association of Historians of Nineteenth-Century Art and have been featured in an article of their Spring 2013 issue. See the modifications to the reader in action by clicking the additional icons in the toolbar area of the upper-right.
The Notes feature is available by setting
br.features.notes = true;
in the reader's config. Likewise Annotations are enabled by settingbr.features.annotations = true;
.The Notes button will return any notes (when available) for the current page by calling the overridable function
getNotes
.The Annotations button will toggle the display of annotated areas of each page. When these areas are clicked they spawn additional popups containing arbitrary HTML content. Their position and content is defined by the
br.annotations
object within the config. You can see how this is set up here.In the example, I've added the content as hidden divs in index.html which then gets pulled into each popup (which is useful for SEO purposes). It could also be included via javascript as part of the
br.notes
andbr.annotations
objects.Please take a look at the live features in the article, and the changes to the code. I'll be happy to answer any questions and work with you to get these features integrated with BookReader.