Replace STOP RUN with GOBACK #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hartanto Ario Widjaya <tanto259@users.noreply.github.com>
|
@paulnewt any thoughts on this? If accepted, we will need to update the COBOL programs on the system. |
|
STOP RUN replaced with GOBACK in all source located in ZOS.PUBLIC.SRC, ZOS.PUBLIC.ADHOC,CBL, and ZOS.PUBLIC.DB2.CBL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hartanto Ario Widjaya tanto259@users.noreply.github.com
One of the issue with having
STOP RUNis that it causes problems with subroutine CALL. In particular if a user decide to call a subroutine twice, and the subroutine contain aSTOP RUN, the entire thing will terminate before the second execution.In particular, this may have causes this issue on Slack: https://openmainframeproject.slack.com/archives/C011NE32Z1T/p1611697726073500
Thus, I believe it's in the best interest to replace all occurrence of
STOP RUNtoGOBACKsince the programs will terminate more gracefully (i.e. the CALL-ed program will return control back to the caller instead of terminating everything).