updating the Getting Started course images #233
Conversation
Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
|
Yay!
Maybe you want to add the accompanying steps for the images?
If you want, you can duplicate
I agree :) Also, it seems that image097, image106 and image121 contains your personal ID. Might want to change them for privacy reason. |
| WORKING-STORAGE. | ||
| 01 FACIAL-EXP PIC X(11) VALUE SPACES. | ||
| 88 HAPPY VALUE 'HAPPY'. | ||
| .... | ||
| .... | ||
| PROCEDURE DIVISION. | ||
| .... | ||
| .... | ||
| PERFORM SAY-SOMETHING-DIFFERENT UNTIL HAPPY | ||
| PERFORM SAY-SOMETHING-DIFFERENT BY FACIAL-EXP UNTIL 'HAPPY' | ||
| END-PERFORM. | ||
| ``` | ||
|
|
||
| *Example 5. PERFORM statement with 88-level conditional name* | ||
| *Example 5. PERFORM statement* | ||
|
|
||
|
|
||
| It is also possible to use PERFORM statement without the use of a 88-level conditional name, observe Example 6. | ||
|
|
||
| ``` | ||
| WORKING-STORAGE. | ||
| 01 FACIAL-EXP PIC X(11) VALUE SPACES. | ||
| .... | ||
| .... | ||
| PROCEDURE DIVISION. | ||
| .... | ||
| .... | ||
| PERFORM SAY-SOMETHING-DIFFERENT UNTIL FACIAL-EXP = "HAPPY" | ||
| END-PERFORM. | ||
| ``` | ||
|
|
||
| *Example 6. PERFORM statement without 88-level conditional name* | ||
|
|
||
|
|
||
| ### SEARCH statements | ||
|
|
||
| The SEARCH statement searches a table for an element that satisfies the specified condition and adjusts the associated index to indicate that element. Tables, effectively an array of values, are created with an OCCURS clause applied to WORK-STORAGE data-names. A WHEN clause is utilized in SEARCH statements to verify if the element searched for satisfies the specified condition. Assuming FACIAL-EXP has many possible values, then SEARCH WHEN is an alternative conditional expression, observe Example 7. | ||
| The SEARCH statement searches a table for an element that satisfies the specified condition and adjusts the associated index to indicate that element. Tables, effectively an array of values, are created with an OCCURS clause applied to WORK-STORAGE data-names. A WHEN clause is utilized in SEARCH statements to verify if the element searched for satisfies the specified condition. Assuming FACIAL-EXP has many possible values, then SEARCH WHEN is an alternative conditional expression, observe Example 6. | ||
|
|
||
|
|
||
| ``` | ||
| WORKING-STORAGE. | ||
| 01 FACIAL-EXP-TABLE REDEFINES FACIAL-EXP-LIST. | ||
| 05 FACIAL-EXP PIC X(11) OCCURS n TIMES INDEXED BY INX-A. | ||
| 88 HAPPY VALUE "HAPPY". | ||
| .... | ||
| .... | ||
| PROCEDURE DIVISION. | ||
| .... | ||
| .... | ||
| SEARCH FACIAL-EXP | ||
| WHEN HAPPY(INX-A) DISPLAY 'I am glad you are happy' | ||
| WHEN 'HAPPY' STOP RUN | ||
| END-SEARCH | ||
| ``` | ||
| *Example 7. SEARCH WHEN statement* | ||
| *Example 6. SEARCH WHEN statement* |
There was a problem hiding this comment.
Also, if you can reverse this changes, that will be great :) It was added in #228 to fix an issue.
There was a problem hiding this comment.
sorry, this was a stupid mistake on my part
| @@ -1657,13 +1677,13 @@ If desired, you can also easily submit a job, wait for it to complete, and downl | |||
| zowe jobs submit ds "Z80462.JCL(HELLO)" -d . | |||
There was a problem hiding this comment.
There are 10 occurrences of this ID being mentioned on this Lab. Maybe we can change it to Z99998?
Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
…-submit-ds-command.png Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
|
|
||
|  | ||
|
|
||
|  | ||
|
|
||
|  |
There was a problem hiding this comment.
Wait, is there any step missing? If I recall correctly, there used to be a base path step here... hmmmm
There was a problem hiding this comment.
yes, you are right.
I will add the missing image + the accompanying steps for the images
Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
| @@ -224,31 +234,47 @@ Follow these steps: | |||
|
|
|||
| 2. Click on the pencil icon to edit your profile. A dialog box opens displaying the current information in your profile, which you can edit as required. | |||
There was a problem hiding this comment.
There is no longer a pencil icon involved. So this line will need changes in the description :)
|
Cannot leave a comment on the code changes, but L424 said that "A small dialog will open asking you for the line you wish to jump to, type 68 and press the enter key". However, in image006, the number being typed is 25, and it might be too small at the PDF? |
|
L472 said that "To demonstrate this, navigate to line 62 of CBL0001, which again is the declaration of the READ-RECORD paragraph." Again the image show line 82, hmm, would it be possible for you to re-take image017 to use the Z99998's CBL0001 instead of the one at the repo? and also change the description since READ-RECORD would start at line 63 :) |
| @@ -562,15 +588,15 @@ The COBOL Language Support extension enables several features for ease of naviga | |||
|
|
|||
| While your cursor is placed on a variable or paragraph name, you can press **F12** or **CTRL+click** to use the **Go To Definition** functionality to display the point in the code where the variable or paragraph is defined. | |||
|
|
|||
|  | |||
|  | |||
|
|
|||
| *Figure 2. Go To Definition shows the point at which the USER-STREET variable is first defined.* | |||
There was a problem hiding this comment.
Need to change USER-STREET to USA-STATE
|
|
||
| *Figure 2. Go To Definition shows the point at which the USER-STREET variable is first defined.* | ||
|
|
||
| ### Find All References | ||
|
|
||
| The **Find All References** functionality (**SHIFT+ALT+F12**) highlights all references to a variable or paragraph and displays them in a list in the sidebar, so that you can easily navigate between them. | ||
|
|
||
|  | ||
|  | ||
|
|
||
| *Figure 3. Find All References lists all references to the USER-STREET variable in the code.* |
There was a problem hiding this comment.
Need to change USER-STREET to STREET-ADDR
|
L1369-1377 indicates a list of things installed with Code4z:
It seems that some of them are no longer included/required, so maybe need to change the list. |
| 14. Again, click on the + to the far right on the Data Sets selection. Result is another prompt to Create a New Connection to z/OS. LearnCOBOL is in the connection list. Select **LearnCOBOL** for the Data Sets available to the previously defined LearnCOBOL connection to z/OS as shown in Figure 15. | ||
|
|
||
|  | ||
|  | ||
|
|
||
| *Figure 15. LearnCOBOL connection* |
There was a problem hiding this comment.
I think with the latest Zowe Explorer, once the profile is created, it's automatically added to the list, so this step will no longer be needed. Need to confirm first though before removing.
There was a problem hiding this comment.
yes you are right, should I replace it with something like "your profile will be added automatically to the DATASET list"
and add a note that "you can click on the + to the far right on the Data Sets selection to see all your connections that are not in the List and be able to add them to the list"
There was a problem hiding this comment.
Hmm, that would be nice I think...
|  | ||
|
|
||
|  | ||
|
|
||
| *Figure 13. Accept connections with self-signed certifications* |
There was a problem hiding this comment.
So, this figure description will need to be updated
|
|
||
| *Figure 26. HELLOCBL output* | ||
|
|
||
|
|
||
|
|
||
| 26. Select **COBRUN:SYSPRINT(101)** to view the COBOL compiler output. Scroll forward in the COBOL compile to locate the COBOL source code compiled into an executable module as shown in Figure 27. Observe the Indicator Area in column 7, A Area beginning in column 8, and B Area beginning in column 12. Also, observe the period (.) scope terminators in the COBOL source. | ||
|
|
||
|  | ||
|  | ||
|
|
||
| *Figure 27. COBOL compiler output* | ||
|
|
||
|
|
||
|
|
||
| 27. View the COBOL program execution by selecting **COBRUN:SYSOUT(105)** from the LearnCOBOL in the Jobs section of Zowe Explorer as shown in Figure 28. |
There was a problem hiding this comment.
Seems like it is now COBRUN:SYSOUT(104)...
| @@ -1647,23 +1685,23 @@ zowe jobs view sfbi JOB00906 105 | |||
|
|
|||
| where `JOB00906` and `105` are obtained from the previous commands. | |||
There was a problem hiding this comment.
Maybe we can change JOB00906 to JOB09413 to match zowe-jobs-submit-ds-and-view-spool-output.png, 105 should be changed to 104 too.
There are also occurrences of JOB00906 and 105 on the few lines above.
|
It seems that image113.png still contains your ID |
|
Same thing with image133, image134. image140 seems to be CBL0001J instead of CBL0003J |
|
image147 should be without the $ symbol, and image148 should be with the $ symbol |
| @@ -3681,7 +3717,7 @@ This lab requires two COBOL programs, CBL0006 and CBL0007 and two respective JCL | |||
|  | |||
There was a problem hiding this comment.
Syntax error on the image.
Should be:
IS-STATE-VIRGINIA.
IF USA-STATE = 'Virginia' THEN
ADD 1 TO VIRGINIA-CLIENTS
END-IF.
Note the . :)
|
That should be all. I think my concern would be some of the images are quite large such that they fill an entire page (or the majority of the page)... not sure how to handle this with Markdown though |
Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
| 1. COBOL Language Support | ||
| 2. Zowe Explorer | ||
| 3. Explorer for Endevor | ||
| 4. HLASM Language Support | ||
| 5. Debugger for Mainframe | ||
| 6. COBOL Control Flow |
There was a problem hiding this comment.
Indentation a bit off for 2-6 :)
|
Might want to change L528 from |
| @@ -3930,15 +3968,14 @@ This lab requires two COBOL programs, CBL0008 and CBL0009 and two respective JCL | |||
|
|
|||
| *Figure 8. Successful compile* | |||
|
|
|||
|
|
|||
| **Lab Hints** | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
The lab hints here reveals the fix for the error directly. Maybe we change it back to show 05 TLIMIT as the previous version?
There was a problem hiding this comment.
Yup! I believe the original image169 is like that :)
|
Do you think we can fix image149, image150 and image151? The original image is from https://publibfp.boulder.ibm.com/epubs/pdf/igy6lr30.pdf, page 280, 276, and 290 of the PDF respectively. If not, we can left them be :) |
Do you mean retake them or did I misunderstand? |
Oops, my bad. I meant replacing them with a higher quality image |
…lab hint Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
Signed-off-by: ahmedEid1 <ahmedeid6422@gmail.com>
|
I think we can approve and merge this PR (@ahmedEid1 if you agree, just give me a 👍 ). As a future PR, we could also update images 107 & 108 in the Data Division chapter, images 125-131 in the File Handling chapter, images 141-145 in the File Output chapter, images 000-002 & 162-163 in the Arithmetic expressions chapter. We could use the syntax highlighting provided by the COBOL Language Support VS Code Extension to perform the update. This would make the content more familiar to those using VS Code to complete the labs. |
Signed-off-by: ahmedEid1 ahmedeid6422@gmail.com
Updated:
Not updated:
Notes
ps: kept the old name of the images for ease of comparison
Suggestion: