Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in binary-ranges-3.png (Length and Range at S9(9) is wrong #282 #284

Merged
merged 2 commits into from Nov 4, 2022

Conversation

vargajb
Copy link
Contributor

@vargajb vargajb commented Nov 3, 2022

Proposed changes

There were a few typos in the binary-ranges-?.png images. See details in issue #282. I modified the png's and attached the xlsx from which the corrected images were generated, in case it needs to be modified.

Fixes #282

Type of change

What type of changes does your PR introduce to the COBOL Programming Course? Put an x in the boxes that apply.

  • Bug fix (change which fixes one or more issues)
  • New feature (change which adds functionality or features to the course)
  • Translations (change which adds or modifies translations of the course)
  • Documentation (change which modifies documentation related to the course)
  • This change requires an update to the course's z/OS environment

Checklist:

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the Contributing Guideline
  • I have included a title and description for this PR
  • I have DCO-signed all of my commits that are included in this PR
  • I have tested it manually and there are no regressions found
  • I have commented my code, particularly in hard-to-understand areas (if appropriate)
  • I have made corresponding changes to the documentation (if appropriate)

Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @vargajb!

@tanto259 tanto259 merged commit da3b402 into openmainframeproject:master Nov 4, 2022
@tanto259 tanto259 added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in binary-ranges-3.png (Length and Range at S9(9) is wrong
2 participants