Limit the length of rd.zfcp when refresh bootmap #329

changzhi1990 · 2020-08-04T01:56:31Z

In the boot from volume scenario for RHEL, the VM may fail if the length of kernel parameter line exceeds the maximum allowed. So the production recommend is 8 different paths of rd.zfcp.

If the count of FCP devices is greater than 8, it will report an error and exit directly.

If the count of WWPN is greater than 8, it will report a warning and don't exit.

changzhi1990 · 2020-08-04T02:00:12Z

Boot from volume maybe fails at the refreshbootmap stage for length of kernel parameter line exceed the maximum allowed. So the production recommend is 8 paths of rd.zfcp.

If the count of FCP devices is greater than 8, it will report an error and exit directly.

If the count of WWPN is greater than 8, it will report a warning and don't exit.

changzhi1990 · 2020-08-04T02:01:39Z

With this pr, if the path is less than 8, it would work fine. If the path is greater than 8, the output is:

[root@rhel82-com ~]# sudo /opt/zthin/bin/refresh_bootmap --fcpchannel=5c73,5d73,5c74,5c71,5d74 --wwpn=5005076802100C1A,5005076802200C1A,5005076802400C1A,5005076802300C1A,5005076802300C1B,5005076802200C1B,5005076802100C1B,5005076802400C1B --lun=0000000000000000
zthinUserID is CHAZ00D4
multipathd service is active and running.
Error: non-zero CP response for command 'q fcp': #40
Done
Done
Done
Done
Done
These WWPNs will be operated: 5005076802400c1a 5005076802400c1b
/dev/disk/by-path/ccw-0.0.5c73-zfcp-0x5005076802400c1a:0x0000000000000000 is: /dev/disk/by-path/ccw-0.0.5c73-zfcp-0x5005076802400c1a:0x0000000000000000
/dev/disk/by-path/ccw-0.0.5d73-zfcp-0x5005076802400c1a:0x0000000000000000 is: /dev/disk/by-path/ccw-0.0.5d73-zfcp-0x5005076802400c1a:0x0000000000000000
/dev/disk/by-path/ccw-0.0.5c74-zfcp-0x5005076802400c1a:0x0000000000000000 is: /dev/disk/by-path/ccw-0.0.5c74-zfcp-0x5005076802400c1a:0x0000000000000000
/dev/disk/by-path/ccw-0.0.5d74-zfcp-0x5005076802400c1a:0x0000000000000000 is: /dev/disk/by-path/ccw-0.0.5d74-zfcp-0x5005076802400c1a:0x0000000000000000
Multipath is enabled, using multipath devNode: /dev/disk/by-id/dm-uuid-part1-mpath-36005076802880052a000000000004047.
Begin to refreshZIPL.
devNode is: /dev/disk/by-id/dm-uuid-part1-mpath-36005076802880052a000000000004047 point: /mnt/qySgR
Use as much as possible of FCP devices: 5d74 5d73 5c74 5c71 5c73 and WWPN: 5005076802400c1a 5005076802400c1b rd.zfcp: 5d74,0x5005076802400c1a 5d73,0x5005076802400c1b 5c74,0x5005076802400c1a 5c71,0x5005076802400c1b 5c73,0x5005076802400c1a 5d74,0x5005076802400c1b 5d73,0x5005076802400c1a 5c74,0x5005076802400c1b
Refresh rhel78 zipl.
Updating /mnt/qySgR/etc/fstab
Move stale multipath bindings and wwids if any
WWPNs: 5005076802400c1a 5005076802400c1b
FCPs: 5d74 5d73 5c74 5c71 5c73
Begin to cleanup umount dir.
Finish cleanuping umount dir.
Begin to disconnect FCPs
Disconnect FCP device: 5d74
Disconnect FCP device: 5d74
FCP device 5d74 has already detached.
Disconnect FCP device: 5d73
Disconnect FCP device: 5d73
FCP device 5d73 has already detached.
Disconnect FCP device: 5c74
Disconnect FCP device: 5c74
FCP device 5c74 has already detached.
Disconnect FCP device: 5c71
Disconnect FCP device: 5c71
FCP device 5c71 has already detached.
Disconnect FCP device: 5c73
Disconnect FCP device: 5c73
FCP device 5c73 has already detached.
Finish disconnecting FCPs.
Begin to refresh multipath bindings.
Cleaning up multipath bindings and wwids.
Finish refreshing multipath bindings.

dongyanyang · 2020-08-04T02:25:24Z

zthin-parts/zthin/bin/refresh_bootmap

-  do
-    for w in ${wwpns[@]}
+
+  # For rhel8.x, the max support items of "rd.zfcp" is 8, so we need to judge the


not only rhel8.x

dongyanyang · 2020-08-04T02:25:57Z

zthin-parts/zthin/bin/refresh_bootmap

@@ -295,14 +295,59 @@ function refreshZIPL {
    os=$os$version
  fi
  # Prepare the new rd.zfcp parameter value
+  fcps_len=${#fcps[@]}
+  wwpns_len=${#wwpns[@]}
+  res=$(( $fcps_len * $wwpns_len ))


I assume we have handled the case when fcps_len or wwpns_len is zero?

dongyanyang · 2020-08-04T02:37:30Z

zthin-parts/zthin/bin/refresh_bootmap

+  fi
+
+  # Check the count of WWPN, if greater than 8, warning and don't exit.
+  wwpns_len=${#wwpns[@]}


should check after get the real wwpn, here the wwpn is the passed in parameters.

dongyanyang · 2020-08-04T02:38:31Z

zthin-parts/zthin/bin/refresh_bootmap

+  fcps_len=${#fcps[@]}
+  if [ $fcps_len -gt 8 ]
+  then
+      inform "ERROR: The count of FCP devices can't greater than 8."


The FCP channel count %d is greater than 8.

dongyanyang · 2020-08-04T02:52:55Z

zthin-parts/zthin/bin/refresh_bootmap

+  # If the result of fcps_len multiply wwpns_len greater than 8, we need to use
+  # every FCP device and as much as possible to use WWPN.
+  else
+    if [ $fcps_len -gt $wwpns_len ];then


These code logic can be simplified.

dongyanyang · 2020-08-04T07:01:34Z

@bjhuangr @jichenjc pls help to review, thanks

bjhuangr · 2020-08-04T13:44:47Z

@changzhi1990 The code change looks good to me. Please add some words to describe the change into commit message.

dongyanyang · 2020-08-07T01:40:02Z

zthin-parts/zthin/bin/refresh_bootmap

+          wwpn_index=0
+        fi
+
+        x=${fcps[$fcp_index]},0x${wwpns[$wwpn_index]}" "


missing $lun?

changzhi1990 · 2020-08-10T06:37:01Z

For 4 FCPs and 4 WWPNs scenarios, the output is:

Aug 10 02:33:19 112-cmp-cz root[31258]: 28492.0 refresh_bootmap: refresh_bootmap: refreshZIPL: Use as much as possible of FCP devices: 1d0c 1b0b 1c09 1a09 and WWPN: 500507680b25bac6 500507680b25bac7 500507680b26bac6 500507680b26bac7 rd.zfcp: rd.zfcp=0.0.1d0c,0x500507680b25bac6,0x0000000000000000 rd.zfcp=0.0.1b0b,0x500507680b25bac7,0x0000000000000000 rd.zfcp=0.0.1c09,0x500507680b26bac6,0x0000000000000000 rd.zfcp=0.0.1a09,0x500507680b26bac7,0x0000000000000000 rd.zfcp=0.0.1d0c,0x500507680b25bac7,0x0000000000000000 rd.zfcp=0.0.1b0b,0x500507680b26bac6,0x0000000000000000 rd.zfcp=0.0.1c09,0x500507680b26bac7,0x0000000000000000 rd.zfcp=0.0.1a09,0x500507680b25bac6,0x0000000000000000

The VM works fine:

bjhuangr

Please add the commit message

In the boot from volume scenario for RHEL, the VM may fail if the length of kernel parameter line exceeds the maximum allowed. So the production recommend is 8 different paths of rd.zfcp. If the count of FCP devices is greater than 8, it will report an error and exit directly. If the count of WWPN is greater than 8, it will report a warning and don't exit. Signed-off-by: changzhi <changzhi1990@gmail.com>

changzhi1990 · 2020-08-11T03:28:38Z

Please add the commit message

done

…t#329) In the boot from volume scenario for RHEL, the VM may fail if the length of kernel parameter line exceeds the maximum allowed. So the production recommend is 8 different paths of rd.zfcp. If the count of FCP devices is greater than 8, it will report an error and exit directly. If the count of WWPN is greater than 8, it will report a warning and don't exit. Signed-off-by: changzhi <changzhi1990@gmail.com> Co-authored-by: changzhi <changzhi1990@gmail.com>

changzhi1990 force-pushed the limit_length_rd_zfcp branch from 2ea6fdc to 2b89d74 Compare August 4, 2020 01:56

dongyanyang reviewed Aug 4, 2020

View reviewed changes

changzhi1990 force-pushed the limit_length_rd_zfcp branch 3 times, most recently from 3e91dff to b830ae9 Compare August 4, 2020 05:37

dongyanyang approved these changes Aug 4, 2020

View reviewed changes

bjhuangr approved these changes Aug 4, 2020

View reviewed changes

changzhi1990 force-pushed the limit_length_rd_zfcp branch from b830ae9 to d55b4c0 Compare August 6, 2020 02:10

dongyanyang reviewed Aug 7, 2020

View reviewed changes

changzhi1990 force-pushed the limit_length_rd_zfcp branch from d55b4c0 to 047e2ad Compare August 10, 2020 06:32

changzhi1990 requested a review from bjhuangr August 10, 2020 07:15

bjhuangr requested changes Aug 10, 2020

View reviewed changes

changzhi1990 force-pushed the limit_length_rd_zfcp branch from 2f9d31c to e19188b Compare August 11, 2020 03:28

Merge branch 'master' into limit_length_rd_zfcp

d77b636

changzhi1990 requested a review from bjhuangr August 11, 2020 03:29

bjhuangr approved these changes Aug 11, 2020

View reviewed changes

bjhuangr merged commit d247d47 into openmainframeproject:master Aug 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Limit the length of rd.zfcp when refresh bootmap #329

Limit the length of rd.zfcp when refresh bootmap #329

changzhi1990 commented Aug 4, 2020 •

edited

changzhi1990 commented Aug 4, 2020

changzhi1990 commented Aug 4, 2020 •

edited

dongyanyang Aug 4, 2020

dongyanyang Aug 4, 2020

changzhi1990 Aug 4, 2020

dongyanyang Aug 4, 2020

dongyanyang Aug 4, 2020

dongyanyang Aug 4, 2020

dongyanyang commented Aug 4, 2020

bjhuangr commented Aug 4, 2020

dongyanyang Aug 7, 2020

changzhi1990 commented Aug 10, 2020

bjhuangr left a comment

changzhi1990 commented Aug 11, 2020

Limit the length of rd.zfcp when refresh bootmap #329

Limit the length of rd.zfcp when refresh bootmap #329

Conversation

changzhi1990 commented Aug 4, 2020 • edited

changzhi1990 commented Aug 4, 2020

changzhi1990 commented Aug 4, 2020 • edited

dongyanyang Aug 4, 2020

Choose a reason for hiding this comment

dongyanyang Aug 4, 2020

Choose a reason for hiding this comment

changzhi1990 Aug 4, 2020

Choose a reason for hiding this comment

dongyanyang Aug 4, 2020

Choose a reason for hiding this comment

dongyanyang Aug 4, 2020

Choose a reason for hiding this comment

dongyanyang Aug 4, 2020

Choose a reason for hiding this comment

dongyanyang commented Aug 4, 2020

bjhuangr commented Aug 4, 2020

dongyanyang Aug 7, 2020

Choose a reason for hiding this comment

changzhi1990 commented Aug 10, 2020

bjhuangr left a comment

Choose a reason for hiding this comment

changzhi1990 commented Aug 11, 2020

changzhi1990 commented Aug 4, 2020 •

edited

changzhi1990 commented Aug 4, 2020 •

edited