Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenBLAS #9

Merged
merged 13 commits into from
Nov 6, 2019
Merged

Add OpenBLAS #9

merged 13 commits into from
Nov 6, 2019

Conversation

edelsohn
Copy link
Contributor

@edelsohn edelsohn commented Nov 6, 2019

I'm not certain what to list for crunchbase record for OpenBLAS.

I think that you need to cherry-pick the openblas changes because the pull request seems to include the earlier commits from the main repo that I pulled to get back into sync for this new pull request.

@netlify
Copy link

netlify bot commented Nov 6, 2019

Deploy preview for omp-landscape ready!

Built with commit c324f1a

https://deploy-preview-9--omp-landscape.netlify.com

@dankohn
Copy link
Collaborator

dankohn commented Nov 6, 2019

I created a new nonprofit Crunchbase entry for OpenBLAS. Going forward, you want to sync your fork with the upstream repo and then do these submissions on a branch of your fork to avoid conflicts.

@edelsohn
Copy link
Contributor Author

edelsohn commented Nov 6, 2019

Thanks for merging it. I specifically pulled the OMP head into my fork before creating the new pull request. Github did something strange with the pull and merge into my fork initiated on the web interface.

@dankohn
Copy link
Collaborator

dankohn commented Nov 6, 2019

Right. The issue is that we squash commits so your master now differs from upstream master. That's what you want to make submissions off of a branch, so you can just delete it when it's merged and then resync your master to the upstream master.

@dankohn
Copy link
Collaborator

dankohn commented Nov 6, 2019

Also, I haven't merged. @jmertic owns the landscape. @edelsohn please add an LGTM if it does to you:

https://deploy-preview-9--omp-landscape.netlify.com/selected=open-blas

@edelsohn
Copy link
Contributor Author

edelsohn commented Nov 6, 2019

LGTM. I'll defer to you two on the final decisions.

@jmertic jmertic merged commit ce12966 into openmainframeproject:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants