Fixing Creation of Opensuse data Files #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Princee215 ..works really well..just some minor fixes thats all |
|
@Princee215 lemme know when you have fixed the changes I have suggested .. I would love to approve this PR |
arshPratap
reviewed
Aug 27, 2023
bin/package_build.py
Outdated
| print("Couldn't pull. Error: ",str(e)) | ||
| else: | ||
| data = json.loads(data_source) | ||
| regex_pattern = r"-(.*?)-" |
There was a problem hiding this comment.
@Princee215 could you move the regex_pattern above (its seems like a constant), ... define it just below source_data list
bin/package_build.py
Outdated
| data_dict = {"packageName":package_name,"description":"","version":version} | ||
| opensuse_list.append(data_dict) | ||
| q_index = q[i] | ||
| file_name = f'{DATA_FILE_LOCATION}/{q_index}' |
There was a problem hiding this comment.
rename q_index to file_name and rename the file_name to file_path
bin/package_build.py
Outdated
| file_name = f'{DATA_FILE_LOCATION}/{q_index}' | ||
| with open(file_name,'w') as file: | ||
| json.dump(opensuse_list,file,indent=2) | ||
| print(f"Saved!\nfilename: {q_index}") |
There was a problem hiding this comment.
remove q_index and rename as defined above
|
Sure, thanks @arshPratap, i see these changes. And I'll try to edit as soon as possible. |
Signed-off-by: Princee215 <princeesingh215@gmail.com>
Princee215
force-pushed
the
opensuse_extraction
branch
from
64a1abe
to
d76d243
Compare
pleia2
approved these changes
Aug 29, 2023
|
Great Work @Princee215 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #145 issue. All the OpenSUSE data files that are being generated have an empty JSON file, that was due to a buggy code that Arsh and I tried to correct. We use to have separate chunk of code for creation of different files, In this PR I've use nested for loop and try to reduce down the repetition and the lines of code.
Once this get a green flag, I'll subsequently update the data files in the data repository that are empty right now.
@pleia2 and @arshPratap please take a look and let me know if there's anything that needs to be done.