Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[schema][poi] add ATM and parcel lockers to schema to POI layer #1370

Closed
ttomasz opened this issue Mar 29, 2022 · 4 comments · Fixed by #1375 or #1390
Closed

[schema][poi] add ATM and parcel lockers to schema to POI layer #1370

ttomasz opened this issue Mar 29, 2022 · 4 comments · Fixed by #1375 or #1390

Comments

@ttomasz
Copy link
Contributor

ttomasz commented Mar 29, 2022

Description

I saw that ATM were considered to be included in POI layer in #15 and I would like to propose opening the discussion again.
Additionally with new tagging for parcel lockers I think it would be beneficial to add them too.
I'm bundling them in this request together due to similarities in how name/brand/operator tag is used which I'll explain in a further section.

I'd like to see these at the highest zoom level (currently 14) since they would be relevant only when looking at a small area and for styles that want to show shops etc.

Rationale

ATM

These are commonly used machines and people might want to see them on the map as they try to navigate to them.
There are about 190k features mapped in OSM which is quite significant but shouldn't cause the tiles to get too big and processing shouldn't be affected since they are pretty much just nodes.

I didn't see any more suitable class so I think using "atm" as class would be fine.

tag: amenity=atm
proposed class: atm

Parcel lockers

These are functionally similar to post boxes which are already in "post" class. They are highly popular in some countries e.g. Poland and similarly people might want to see them on the map when they try to find them so they can use them.
Recently proposal was approved by community changing their tagging from subclass of vending machine to their own tag under amenity.
There are few thousand of them mapped currently (plus another 10k with old tagging waiting to be retagged) but total number of machines in Poland is something around 18k and they are gaining popularity in Germany (GLS or DHL have their own machines), USA (Amazon is starting to set up their parcel hubs) and other countries.
Similarly to ATMs they are pretty much just points.

tag: amenity=parcel_locker
proposed class: post (or whatever post_box is in)

name vs brand/operator

ATMs, parcel lockers, and post boxes have a property in common: they do not rely on name tag, they mostly use brand or operator values and sometimes - mostly parcel lockers - ref.

Not sure how this could be solved here... We could overwrite name with brand or operator value but not sure how that plays with name:XX for different languages. Adding additional fields like brand or operator doesn't seem feasible.

@TomPohys
Copy link
Member

TomPohys commented Apr 1, 2022

Thanks for bringing this up. I think that atm and parcel_locker should be part of the schema. The two separate PRs for adding these is very welcome.

The name vs brand/operator problem could be handled as if there is name, use name, if not, use brand. If not name or brand, use operator. If there is no name or brand/operator, do not include it in vector tiles.

The name:xx will probably not be handled at all due to the missing wikidataid or any name:xx tags for the feature.

@ttomasz
Copy link
Contributor Author

ttomasz commented Apr 5, 2022

Thanks. I'll try making the PRs and see how it goes :)

@ttomasz
Copy link
Contributor Author

ttomasz commented Apr 18, 2022

@TomPohys I created PR for ATMs

@TomPohys TomPohys linked a pull request Apr 25, 2022 that will close this issue
@ttomasz
Copy link
Contributor Author

ttomasz commented May 30, 2022

@TomPohys I created the second PR with parcel locker features

TomPohys pushed a commit that referenced this issue Jun 1, 2022
closes #1370 

This PR adds a parcel locker to post class.

Similarly to ATMs from PR #1375 if a name is not present we try to use `brand` or `operator`. Here we also try to add `ref` to the brand or operator since it can disambiguate parcel lockers that are next to each other (which happens).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants