Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[review] POI layer #15

Closed
ImreSamu opened this issue Nov 5, 2016 · 4 comments
Closed

[review] POI layer #15

ImreSamu opened this issue Nov 5, 2016 · 4 comments
Labels

Comments

@ImreSamu
Copy link
Collaborator

ImreSamu commented Nov 5, 2016

If you have a feedback about POI layer - comment to this issue ...

Analyzing what is missing ( based on Taginfo count )

SQL Output: (secret gist ) : https://gist.github.com/ImreSamu/a666974defc8c67da494349239b30045
based on 2016.nov.04 taginfo data and imposm3 mapping
( ~ select key,value, count_all from taginfo where not in [['imposm3_mapping']] order by count_all desc Limit 100 )

My rule of thumb :

  • has a MAKI icon ? ( manual checking , so not fool safe )
  • taginfo count_all >= xxxx
  • I know as a OSM mapper ? ( personal feelings )

My suggestion for the NEW POI-s based on the SQL output ..

should

   key   |         value          | count_all 
---------+------------------------+-----------
 amenity | drinking_water         |    127332   ! https://github.com/mapbox/maki/blob/master/icons/drinking-water-11.svg
 amenity | ice_cream              |      8726   ! https://github.com/mapbox/maki/blob/master/icons/ice-cream-11.svg 
 shop | car_parts             |     24385  !
 shop | variety_store         |     17220  ! 
 shop | tyres                 |     10265  !
 sport | football                    |      3418   !
 sport | fitness                     |      2347   !

maybe

   key   |         value          | count_all 
---------+------------------------+-----------
 amenity | atm                    |    109383   ?
 amenity | hunting_stand          |     85403   ? ( for outdoor )
 amenity | vending_machine        |     82017   ? ( city maps)
 amenity | social_facility        |     47957   ? 
 amenity | clinic                 |     36680   ?
 amenity | charging_station       |      9624   ?
 amenity | emergency_phone        |      4828  ?
 shop | funeral_directors     |      7484  ?
 shop | farm                  |      6554  ?
 shop | seafood               |      5851  ?
 shop | kitchen               |      5040  ?
 shop | paint                 |      4756  ?
 shop | trade                 |      4356  ?
 shop | bookmaker             |      3839  ?
 shop | estate_agent          |      3808  ?
 shop | pawnbroker            |      3756  ?
 shop | lottery               |      3680  ?
 shop | houseware             |      3511  ?
 shop | fashion               |      3208  ?
 sport | 10pin                       |      2104   ?
 sport | exercise                    |      1594   ?
 sport | trampoline                  |      1226   ?
 sport | softball                    |      1007   ?
 sport | 9pin                        |      1005   ?
 leisure | sauna               |      5276   ?
 leisure | fitness_centre      |      4812   ?
 leisure | fitness_station     |      4387   ?
 leisure | horse_riding        |      3876   ?

edited:

@lukasmartinelli
Copy link
Contributor

lukasmartinelli commented Nov 15, 2016

@bearnxx You also mentioned POI labels in OSM2VectorTiles?
Any ideas or additions?

@ImreSamu I agree with your should and actually also with all of the *maybe to add to the POI layer.
POI layer is not of utmost importance for us now since it is not really features heavily in any of the https://github.com/openmaptiles/openmaptiles-gl-styles but I am very willing to improve it.
I don't have a strong opinion except not to clutter it with invisible/not displayable POIs.

@lukasmartinelli
Copy link
Contributor

POI layer is still something that can be greatly improved if someone wants to.

@ImreSamu
Copy link
Collaborator Author

ImreSamu commented Jan 9, 2017

POI layer is still something that can be greatly improved if someone wants to

we should add this to the ROADMAP.md :)

@nuharaf
Copy link

nuharaf commented Nov 29, 2018

I found building:use=education used in my campus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants