Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fitness_station and picnic_table POIs #56

Open
kudlav opened this issue Jul 18, 2021 · 6 comments
Open

Add fitness_station and picnic_table POIs #56

kudlav opened this issue Jul 18, 2021 · 6 comments

Comments

@kudlav
Copy link
Contributor

kudlav commented Jul 18, 2021

Hi,
I think it would be really usefull to display fitness_station and picnic_table.

But I did not find it in getPoiClass.ts or openmatiles poi.yam.

I found fitness_station in the following PR openmaptiles/openmaptiles#15 but fitness_stations are still not included in OpenMapTiles demo.

@zbycz
Copy link
Owner

zbycz commented Jul 27, 2021

Hi,

the getPoiClass works like this: if it finds a leisure=fitness_station tag (see), it looks for the "fitness_station_11.svg" in /public/icons folder.

You can create a pull request with just the one (or two) icons.

@zbycz
Copy link
Owner

zbycz commented Jul 27, 2021

Can you link/screenshot the specific issue? I am not sure if I answered your question :)

@kudlav
Copy link
Contributor Author

kudlav commented Jul 27, 2021

https://osmapp.org/49.208301,16.620516#18.96/49.2083/16.6206
there is this fitness_station: https://www.openstreetmap.org/way/389797459

So there is need to add different icon for fitness_station or every single tag that should be rendered?
I think, https://osmapp.org/icons/fitness_centre_11.svg or pitch_11.svg is fine.

@zbycz
Copy link
Owner

zbycz commented Jul 28, 2021

I see. It is missing in the map, because the maptiler tiles are refreshed only once a month.

Though I want to setup my own OpenMapTiles instance, which would be refreshed minutely.

BTW, you can display any osm item on osmapp by just changing the URL like this:

https://osmapp.org/way/389797459

@kudlav
Copy link
Contributor Author

kudlav commented Jul 28, 2021 via email

@zbycz
Copy link
Owner

zbycz commented Jul 28, 2021

I see, so in this case. The OpenMapTiles project doesnt process this kind of POI yet.

Please ask them at https://github.com/openmaptiles/openmaptiles/issues and be sure to mention this issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants