New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update makefile for hierarchical area names #1009
Conversation
- Use `find` instead of `wildcard` to detect existing `.osm.pbf` files - Use `patsubst` to extract an `area` from a filename - Clarify messssage, especially for errors Resolve openmaptiles#1008
Results evaluating commit dacd9cf (merged with base 883a997 as 8274afc). See run details. PostgreSQL DB size in MB: 2665 ⇒ 2605 (-2.3% change)
expand for details...
|
@nyurik, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm fine with this, but one issue others may have is that this makes the script linux/macOS only, whereas before it was "kinda" able to run on Windows too (at least that's what I heard).
I've tested this PR on both Windows and Linux. AFAIK, the OMT project requires a
A |
Thanks @zstadler. |
find
instead ofwildcard
to detect existing.osm.pbf
filespatsubst
to extract anarea
from a filenameResolve #1008