Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update makefile for hierarchical area names #1008

Closed
zstadler opened this issue Sep 29, 2020 · 0 comments · Fixed by #1009
Closed

Update makefile for hierarchical area names #1008

zstadler opened this issue Sep 29, 2020 · 0 comments · Fixed by #1009

Comments

@zstadler
Copy link
Contributor

Update make to detect existing osm.pbf files of hierarchical area names like europe/monaco.

For example:

$ make download area=europe/monaco

Followed by

$ ls data/europe/monaco.osm.pbf
data/europe/monaco.osm.pbf
$ make import-osm
Starting postgres docker compose target using default image (no recreate if exists)
Creating openmaptiles_postgres_1 ... done

ERROR: The 'area' parameter or environment variable have not been set, and there is no data/*.osm.pbf file

  make import-osm area=<area-id>

To download an area, use   make download <area-id>
To list downloadable areas, use   make list-geofabrik   and/or   make list-bbbike
Makefile:343: recipe for target 'import-osm' failed
make: *** [import-osm] Error 1
zstadler added a commit to zstadler/openmaptiles that referenced this issue Sep 29, 2020
@zstadler
Update makefile for hierarchical area names
b870642 
- Use `find` instead of `wildcard` to detect existing `.osm.pbf` files
- Use `patsubst` to extract an `area` from a filename
- Clarify messssage, especially for errors

Resolve openmaptiles#1008
@zstadler zstadler mentioned this issue Sep 29, 2020
Merged
TomPohys pushed a commit that referenced this issue Oct 1, 2020
@zstadler
Update makefile for hierarchical area names (#1009)
e8bf4aa 
- Use `find` instead of `wildcard` to detect existing `.osm.pbf` files
- Use `patsubst` to extract an `area` from a filename
- Clarify messssage, especially for errors

Resolve #1008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update makefile for hierarchical area names zstadler/openmaptiles
1 participant
@zstadler