Allow BBOX to be set in .env file
#1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `BBOX` setting in `.env` is ignored for all areas except `planet`. On the other hand, the `planet` area is an overkill for any `BBOX` setting other than the default - `-180.0,-85.0511,180.0,85.0511`. With this PR, `quickstart.sh` would not override a modified `BBOX` value in `.env`. Also, this provides a way to avoid the pessimistic `BBOX` computation for `osmfr` extracts, as described in openmaptiles/openmaptiles-tools#297 (comment)
|
I expect this PR to work well also with the planned replacement of |
zstadler
changed the title
BBOX to be set in .env fileBBOX to be set in .env file
nyurik
reviewed
Oct 1, 2020
There was a problem hiding this comment.
I think your PR may conflict with https://github.com/openmaptiles/openmaptiles/pull/1012/files
|
Results evaluating commit 421e18b (merged with base 341c4df as 290d0aa). See run details. PostgreSQL DB size in MB: 2665 ⇒ 2593 (-2.7% change)
expand for details... |
|
I believe there is no functional conflict between #1012 and this PR. When combined, if |
|
Hi @zstadler, thanks for PR. I think that the I think that change a |
|
Hi @TomPohys First, a confession - I'm a proud user of Unlike all other settings in the
Hopefully these PRs will be the last step in a long process of cleaning-up legacy complications, a process that began with the removal of |
|
Hi @zstadler, sorry for the delayed answer. I still thinking about this. It can be very confusing, that change in manual steps are now like - if there is *.bbox file, take bbox from *.bbox, if there is not *.bbox, take bbox from .env for quickstart will be like - if not an I understand, that now is not possible to change bbox for quickstart, but it works every time with the right bbox for the downloaded area. |
|
Hi @TomPohys, I'm not sure if your comment is about the proposed user experience or the implementation. I would like to discuss the user experience first. If we agree on the desired "what", we'll proceed to the "how". Currently
Problem statementWhile users of a Proposal
Note: - # BBOX may get overwritten by the computed bbox of the specific area:
- # make generate-dc-config
- BBOX=-180.0,-85.0511,180.0,85.0511
+ # By default, tile generation is done for the full extent of the given area.
+ # Un-comment and set BBOX below to overwrite it.
+ # BBOX=-180.0,-85.0511,180.0,85.0511 |
|
Hi @zstadler, thank you again. Let's use it. Change bbox for Let's keep the comment about bbox in Thanks |
Service using OpenMapTiles background
|
Thanks, looks good. I just change bbox site that using the OpenMapTiles background map. |
TomPohys
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
BBOXsetting in.envis ignored for all areas exceptplanet.On the other hand, the
planetarea is an overkill for anyBBOXsetting other than the default --180.0,-85.0511,180.0,85.0511.With this PR,
quickstart.shwould not override a modifiedBBOXvalue in.env.Also, this provides a way to avoid the pessimistic
BBOXcomputation forosmfrextracts, as described in openmaptiles/openmaptiles-tools#297 (comment)