Missing islands #605
Merged
Missing islands #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter/ocean areas and cover important islands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #522 and related.
After several experiments - trying to cut holes in
osm_water_polygonto it doesn't cover islands, I decided to not import"natural" = 'bay'intowater_zviews. Bay polygons mostly duplicate another water areas (from osm_water_polygon or osm_ocean_polygon) and are the only ones found covering islands.Bays stay in osm_water_polygon for generating labels in
water_namelayer.Tested on San Francisco area (complete duplicate), Finland (complete duplicate) and Florida. In Florida some parts of water areas are missing in comparison with current OMT version, however not displaying bays corresponds with openstreetmap.org (e.g. https://www.openstreetmap.org/#map=15/30.1273/-85.5190) and I think correction for these cases should be made on data side (according to recommendations here: https://wiki.openstreetmap.org/wiki/Tag%3Anatural%3Dbay).
No changes in style needed.
I tested importing island + islet and removing them from osm_water_polygon (ST_Difference in places where polygons ST_Intersects), but 1) it is really time consuming even only on one land data extract + there is need to store more data in database, 2) there are water polygons on big islands (e.g. https://www.openstreetmap.org/#map=10/60.1989/20.0466) that should not be removed, so there is need of additional conditions --> completely not realistic time.