DAGMC Test via Python Interface #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on't expect a geometry.xml file.
|
Oops, one more is in here too. The |
paulromano
requested changes
Nov 8, 2018
|
Can you remove the extra |
|
@paulromano for sure. Error in the directory move. Thanks! |
paulromano
reviewed
Nov 10, 2018
tests/regression_tests/dagmc/test.py
Outdated
| mats = openmc.Materials([u235, water]) | ||
| model.materials = mats | ||
|
|
||
| harness = HashedPyAPITestHarness('statepoint.5.h5', model=model) |
There was a problem hiding this comment.
Let's stick with PyAPITestHarness so the results don't get hashed (we generally only use that if the results file would be huge). Sorry, last request, I promise!
There was a problem hiding this comment.
Haha no worries! That makes sense. Updating...
paulromano
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for DAGMC with a model setup using the Python interface.
The only external change needed was a check during model export to determine if it uses a DAGMC geometry - in which case no geometry.xml file is created.
This was to avoid having to spoof a universe for the OpenMC geometry like this.