Use /bin/sh as default shell when creating/importing users via WebUI.

Signed-off-by: Volker Theile <votdev@gmx.de>
openmediavault · Oct 26, 2018 · a07a949 · a07a949
1 parent 5cb3fa8
commit a07a949
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/deb/openmediavault/debian/changelog b/deb/openmediavault/debian/changelog
@@ -13,6 +13,7 @@ openmediavault (5.0-1) unstable; urgency=low
 openmediavault (4.1.13-1) stable; urgency=low
 
   * Fix various issues found by the lgtm.com project.
+  * Use /bin/sh as default shell when creating/importing users via WebUI.
   * Issue #182: Remove percentage text in progress bar when config is
     applied. It is not possible to display an accurate value here.
   * Issue #192: Allow to define shell at user import.

diff --git a/deb/openmediavault/usr/share/openmediavault/engined/rpc/usermgmt.inc b/deb/openmediavault/usr/share/openmediavault/engined/rpc/usermgmt.inc
@@ -700,7 +700,7 @@ finish:
 					"password" => $matches[5],
 					"groups" => explode(",", $matches[7]),
 					"disallowusermod" => boolvalEx($matches[8]),
-					"shell" => !empty($matches[6]) ? $matches[6] : "/bin/dash",
+					"shell" => !empty($matches[6]) ? $matches[6] : "/bin/sh",
 					"sshpubkeys" => []
 				];
 				if (!empty($matches[2]) && is_numeric($matches[2]))