Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /bin/sh as default for new users #195

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Use /bin/sh as default for new users #195

merged 1 commit into from
Oct 26, 2018

Conversation

@ThomasKaiser
Copy link
Contributor Author

I hope this one makes it also into this PR

@votdev
Copy link
Member

votdev commented Oct 26, 2018

OMV will still use Dash as default shell. See

If it is necessary to switch this behaviour this can be accomplished via WebUI.

If there are overwhelming or security related reasons to switch to something else than the Debian default we can discuss this.

@votdev
Copy link
Member

votdev commented Oct 26, 2018

Switching to /bin/sh does not help because this is ALWAYS a symlink to Dash.

Ubuntu: (my shell is zsh here)

➜  ceph issue_36480 ✗ ls -alh /bin/sh
lrwxrwxrwx 1 root root 4 Jul 20 09:49 /bin/sh -> dash

Debian:

root@omv4box:/home/vagrant# ls -alh /bin/sh
lrwxrwxrwx 1 root root 4 Jan 24  2017 /bin/sh -> dash
root@omv4box:/home/vagrant# which bash
/bin/bash

@ThomasKaiser
Copy link
Contributor Author

As written already on the forum...

  • /bin/sh is the default shell (not /bin/dash)
  • /bin/sh is by default a symlink to /bin/dash (which allows any admin to change this by linking it to something else and change behavior system wide)
  • It is an UI/UX issue since /bin/dash will get confused with /bin/bash pretty easily

All I'm asking for is really doing what Debian does and that's using /bin/sh as default shell. This won't change anything wrt functionality since as we all know /bin/sh is usually just a symlink to /bin/dash

But it will allow users to spot it easily if they want to create users with /bin/bash instead since now they will most probably simply overlook that dash is not bash (this won't happen if the UI default is sh)

TL;DR: dash and bash look too similar and using /bin/sh will make OMV more compatible to what Debian does:

tk@hermes:~$ lsb_release -c
Codename:	stretch
tk@hermes:~$ grep SHELL /etc/default/useradd
# The SHELL variable specifies the default login shell on your
SHELL=/bin/sh

@votdev
Copy link
Member

votdev commented Oct 26, 2018

tk@hermes:$ lsb_release -c Codename: stretch tk@hermes:$ grep SHELL /etc/default/useradd # The SHELL variable specifies the default login shell on your SHELL=/bin/sh

That's the argument i wanted to see :-)

@votdev votdev merged commit 5cb3fa8 into openmediavault:master Oct 26, 2018
@ThomasKaiser ThomasKaiser deleted the patch-1 branch October 26, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants