[BUG-fix] don't use fancy c++ with /Za option in MSVC #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
up until this commit, we should have green travis and red appveyor |
|
GREEN !!! Ok This works, and I can also compile when |
massich
changed the title
|
We'll make a new tarball once this PR makes it to master. |
|
thx @massich ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[written by Sik]
This PR responds to The problem of using coarse compiler options as a wildcard when doing multiplatform software. Cutting corners to use alternative operators by changing the compiler options (with all its collateral effects) instead of adding the bearly minimum, means that all have been chasing ghosts for 2.5 weeks. It was much easier to just add the alternative macros to those 3 cpp files that need it.
Fix #312. Close #313.