Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in new combat text #38

Closed
skittles1 opened this issue Nov 20, 2013 · 4 comments
Closed

Error in new combat text #38

skittles1 opened this issue Nov 20, 2013 · 4 comments

Comments

@skittles1
Copy link

When a player's or monster's attack misses you, the combat text is mixed up.

Some examples:

's attack Dr Creepy you. (fighting a player, Dr Creepy)
The 's attack baby spider you. (fighting a baby spider)

All other combat text appears to be fine.

@MorbusM59
Copy link

My error, pull request to fix it has been added and is just waiting to get patched in: #33

Thanks a lot for reporting anyways!

@Tyrant82
Copy link

This is on a normal spider also:

The 's attack spider you.

Black Spider is fine.

@MorbusM59
Copy link

Just wanted to point out that this is incorrectly labled as duplicate.

This here is about the screwed up defense message.

The other issue is about the missing killing blow because of an attempt to display a nil value.

Both are fixed but separate fixes.

@Tyrant82
Currently, whenever you avoid, dodge, block or parry an attack, the message is botched because of a missing entry at the start of the message. This leads to the remaining parts of the message shifting.

In detail: The message looks like this internally: %s%s%s's attack %s you.
Each %s stands for a string. 1 is the color of the message, 2 is the article, 3 is the name, 4 is the defense descriptor. This results in ~bThe baby spider's attack misses you.

I accidently put: %s%s's attack %s you.
That means I missed one of the %s at the start, which results in ~bThe 's attack baby spider you.

Again, I'm really sorry about that, a fix is on the way already and awaits patching.

@Tyrant82
Copy link

Thanks for clarification :)

@Daenks Daenks closed this as completed Dec 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants