-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
cc: @manics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally this was just python deps for the OMERO.server. I'm happy for this to be extended to deps for OMERO related scripts (though I think anything that's only for testing should be separate since it more dev than production). Do you want to update the readme to make this clearer?
|
||
# Create ansible.cfg with correct roles_path | ||
- printf '[defaults]\nroles_path=../' >ansible.cfg | ||
- pip install ansible docker-py molecule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I've been capping molecule to 1.20 (following a breaking change from 1.19), but if you're using mostly default config it shouldn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminds me that we probably need a list of the capped versions that we periodically review.
'.molecule/ansible_inventory').get_hosts('all') | ||
|
||
|
||
def test_hosts_file(File): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default example molecule test. Does molecule still run successfully if there aren't any test files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
================= 2 passed, 1 pytest-warnings in 3.25 seconds ==================
vs.
Idempotence test passed.
so I think so.
Perhaps better in the web role, then? cc: @jburel @aleksandra-tarkowska |
web-role might be more suitable in that case |
Ok. Closing in favor of just activating molecule here. Will push everything to web then. |
Useful for writing tests and scripting usage of the API.