Skip to content
This repository has been archived by the owner on Apr 1, 2021. It is now read-only.

Install requests for occasional tasks #3

Closed
wants to merge 3 commits into from

Conversation

joshmoore
Copy link
Member

Useful for writing tests and scripting usage of the API.

@joshmoore joshmoore requested a review from jburel March 3, 2017 12:06
@joshmoore
Copy link
Member Author

cc: @manics

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally this was just python deps for the OMERO.server. I'm happy for this to be extended to deps for OMERO related scripts (though I think anything that's only for testing should be separate since it more dev than production). Do you want to update the readme to make this clearer?


# Create ansible.cfg with correct roles_path
- printf '[defaults]\nroles_path=../' >ansible.cfg
- pip install ansible docker-py molecule
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've been capping molecule to 1.20 (following a breaking change from 1.19), but if you're using mostly default config it shouldn't matter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminds me that we probably need a list of the capped versions that we periodically review.

'.molecule/ansible_inventory').get_hosts('all')


def test_hosts_file(File):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default example molecule test. Does molecule still run successfully if there aren't any test files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

================= 2 passed, 1 pytest-warnings in 3.25 seconds ==================

vs.

Idempotence test passed.

so I think so.

@joshmoore
Copy link
Member Author

Originally this was just python deps for the OMERO.server.

Perhaps better in the web role, then? cc: @jburel @aleksandra-tarkowska

@jburel
Copy link
Member

jburel commented Mar 3, 2017

web-role might be more suitable in that case

@joshmoore
Copy link
Member Author

Ok. Closing in favor of just activating molecule here. Will push everything to web then.

@joshmoore joshmoore closed this Mar 3, 2017
@joshmoore joshmoore deleted the add-requests branch March 3, 2017 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants