New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance and position count fixes for ND2 #1275
Performance and position count fixes for ND2 #1275
Conversation
…the position count
Channel names, emission wavelengths, exposure times, and physical positions are now more completely recorded in MetadataStore.
Reduces the number of skips, and removes System.arraycopy when a very small number of bytes are being copied.
Everything looks good. Please merge. Imported the following files, %ND2 jobs and QA 9438. Performance on Aug4th : Time take for 224 file sets : 6.5 hours Performance on August 21st : Time taken for 224 file sets : 5.80 hours. |
Last commit looks fine and wavelength looks correct in OME-XML. |
Performance and position count fixes for ND2
--rebased-to #1311 |
Fixes https://trac.openmicroscopy.org.uk/ome/ticket/12477 and https://trac.openmicroscopy.org.uk/ome/ticket/12508. I am intentionally leaving 12477 open though, as I think more investigation at the formats-common level is in order (but likely not appropriate for 5.0.x).
To test, verify that jobs are green, and that QA 9438 (corresponding to ticket 12508) has 4 positions and 4 channels. Physical size X and Y should be present, as should exposure times. Initialization times of large .nd2 files (e.g.
nd2/richard
,nd2/guillaume
) should be slightly smaller with this PR included.