-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MATLAB: add logging initialization function #2272
Conversation
This function could be called from scripts or bfopen. If log4j has not been initialized, the Bio-Formats logger are initialized at level WARN by default. Otherwise, this function returns early.
Works as expected,
Good to merge, if the code changes suggested by @jburel are taken care of.. |
@bramalingam / @jburel: pushed. |
@@ -65,12 +65,36 @@ public static String getStackTrace(Throwable t) { | |||
} | |||
|
|||
/** | |||
* Checks wether SLF4J logging has been enabled via logback or log4j |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whether
a typo missed by @mtbc ;-): |
Fixed the typo reported in d76bc0c. Assuming there are no more functional comments and since the merge jobs are green, I propose to merge this PR to unlock this follow-up logging work addressing http://trac.openmicroscopy.org/ome/ticket/13151. |
MATLAB: add logging initialization function
Fixes #2233
This PR addresses the issues reported in #2233 by:
WARN
if no argument is passedbfopen
to prevent logging set by the user to be overridenloci.common.DebugTools
To test this PR:
try the following workflow from a clear MATLAB session using the test artifacts:
check the new MATLAB tests are passing
check
bftest.m
completes as expected in the CI job and that the individual workers in theparfor
loop have their logging system properly intialized.