Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://trello.com/c/TaqXNGco/152-nd2-pixel-offset.
From the Nikon ND2 samples in our repository, it seems like having an odd size both alongside the X dimension and the C dimension is necessary and sufficient to have the scanline padded.
This PR simplifies the
NativeND2Reader.getScanlinePad()
method to use this simpler calculation. To test this PR, check the automated tests keep passing against all ND2 samples. Additionally, test the sample file provided in the Fiji forum thread and check that without this PR, the image display with some horizontal lines while with this PR, it matches the expectation from NIS Elements.