Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bfopen: save individual series' original metadata #573

Merged
merged 2 commits into from Jul 2, 2013

Conversation

melissalinkert
Copy link
Member

Previously the union of all series' original metadata was stored once
for each series. This causes potentially substantially more memory to
be used, and makes it more difficult to read original metadata.

See: http://lists.openmicroscopy.org.uk/pipermail/ome-users/2013-June/003816.html

/cc @sbesson

Previously the union of all series' original metadata was stored once
for each series.  This causes potentially substantially more memory to
be used, and makes it more difficult to read original metadata.
@sbesson
Copy link
Member

sbesson commented Jun 27, 2013

Looks good. Waiting for the corresponding BIOFORMATS-merge-matlab-develop to be green tomorrow.

While modifying this call, thoughts about combining lines 209 and 213 into a single line:

    result{s, 2} = r.getSeriesMetadata();

@melissalinkert
Copy link
Member Author

Code cleanup pushed.

@sbesson
Copy link
Member

sbesson commented Jul 1, 2013

BIOFORMATS-merge-matlab-develop#23 green and happy. Ready to merge.

@melissalinkert
Copy link
Member Author

Merging Tuesday afternoon.

melissalinkert added a commit that referenced this pull request Jul 2, 2013
bfopen: save individual series' original metadata
@melissalinkert melissalinkert merged commit c4cc1f3 into ome:develop Jul 2, 2013
@melissalinkert melissalinkert deleted the bfopen-metadata branch November 6, 2013 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants