Small text update #1320
Merged
Small text update #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reads better to me |
| .. note:: Since OMERO 5.2, the web framework is no longer shipped with the | ||
| Django package and requires manual installation of the Django dependency. | ||
| .. note:: Since OMERO 5.2, the OMERO web framework no longer bundles a copy | ||
| of Django package and requires manual installation of the Django dependency. |
There was a problem hiding this comment.
'a copy of Django package' -> 'a copy of the Django package'
There was a problem hiding this comment.
I think the whole sentence might be better as something like:
Since OMERO 5.2, the OMERO web framework no longer bundles a copy
of the Django package, instead manual installation of the Django dependency
is required.
in both cases.
|
@ximenesuk see now |
Closed
Conflicts: omero/sysadmins/whatsnew.txt
atarkowska
force-pushed
the
django_upgarde
branch
from
87bd8b7
to
ad8dc6b
Compare
|
This all looks good in the commits. It's probably worth double checking on staging before merging. |
|
Staging is fine thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating text as @rleigh-dundee said in #1305
cc: @jburel