Skip to content
This repository has been archived by the owner on Jan 8, 2021. It is now read-only.

Add tubhiswt fileset to the benchmarking suite #17

Merged
merged 6 commits into from
Feb 10, 2017

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Feb 9, 2017

Adds the OME-TIFF tubhiswt fileset to the performance datasets to be benchmarked.

@sbesson
Copy link
Member Author

sbesson commented Feb 9, 2017

@rleigh-codelibre: executing the benchmarking suite, I got

+ /install/bin/metadata-performance-jace 10 /data/tubhiswt-4D/tubhiswt_C0_TP0.ome.tif /data/out/tubhiswt-jace.ome.xml /data/results/tubhiswt-metadata-linux-jace.tsv
loci.formats.FormatException: No TIFF ImageDescription found
terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::lock_error> >'
  what():  boost: mutex lock failed in pthread_mutex_lock: Invalid argument
pass 0: read init...Aborted (core dumped)

The pixeldata JACE and the metadata/pixeldata C++ are all passing as expected. Any thought on what might be wrong here?

@rleigh-codelibre
Copy link
Contributor

I've seen the mutex lock thing locally during program termination. No idea why that happens, but it looks like it's inside the JNI wrappers and hence a bug in either jace itself or in the maven helper stuff. Not something we can easily fix for the benchmarking.

% grep -R "boost.*lock" src/main/jace/jace
src/main/jace/jace/proxy/JValue.h: *     boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/JObject.cpp:   boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/types/JInt.cpp:        boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/types/JByte.cpp:       boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/types/JFloat.cpp:      boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/types/JLong.cpp:       boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/types/JShort.cpp:      boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/types/JDouble.cpp:     boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/types/JChar.cpp:       boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/types/JVoid.cpp:       boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/proxy/types/JBoolean.cpp:    boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/JArray.h:            boost::mutex::scoped_lock lock(javaClassMutex);
src/main/jace/jace/JClassImpl.cpp:              boost::mutex::scoped_lock lock(*mutex);
src/main/jace/jace/JNIHelper.cpp:       boost::mutex::scoped_lock lock(shutdownMutex);
src/main/jace/jace/JNIHelper.cpp:       boost::mutex::scoped_lock lock(shutdownMutex);
src/main/jace/jace/JNIHelper.cpp:       boost::mutex::scoped_lock lock(shutdownMutex);
src/main/jace/jace/JNIHelper.cpp:       boost::mutex::scoped_lock lock(shutdownMutex);
src/main/jace/jace/JNIHelper.cpp:       boost::mutex::scoped_lock lock(shutdownMutex);
src/main/jace/jace/JNIHelper.cpp:       boost::mutex::scoped_lock lock(shutdownMutex);

The actual error is "No TIFF ImageDescription found" which would indicate a problem with the file being opened?

@sbesson
Copy link
Member Author

sbesson commented Feb 10, 2017

Note the last commits here were executed as per https://ci.openmicroscopy.org/job/OME-FILES-performance-win/119/ and on beluga. I can update the IPython notebook with the new data if this makes sense.


# JACE tests
cd $BF_JACE_HOME
/install/bin/metadata-performance-jace 10 /data/BBBC/NIRHTa-001.ome.tiff /data/out/bbbc-jace.ome.xml /data/results/bbbc-metadata-linux-jace.tsv
/install/bin/metadata-performance-jace 10 /data/mitocheck/00001_01.ome.tiff /data/out/mitocheck-jace.ome.xml /data/results/mitocheck-metadata-linux-jace.tsv
# Throws boost: mutex exception
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just run this with || true to avoid the abort? We then get the statistics out of it--the error is only at program termination, not when running the tests.

@rleigh-codelibre
Copy link
Contributor

This all looks fine, just one comment about the jace metadata test.

@rleigh-codelibre
Copy link
Contributor

This all looks good, thanks.

@sbesson sbesson merged commit ab4c952 into ome:master Feb 10, 2017
@sbesson sbesson deleted the tubhiswt-4D branch February 10, 2017 11:51
@sbesson sbesson modified the milestone: 0.1.0 Apr 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants