-
Notifications
You must be signed in to change notification settings - Fork 7
Add tubhiswt fileset to the benchmarking suite #17
Conversation
@rleigh-codelibre: executing the benchmarking suite, I got
The pixeldata JACE and the metadata/pixeldata C++ are all passing as expected. Any thought on what might be wrong here? |
I've seen the mutex lock thing locally during program termination. No idea why that happens, but it looks like it's inside the JNI wrappers and hence a bug in either jace itself or in the maven helper stuff. Not something we can easily fix for the benchmarking.
The actual error is "No TIFF ImageDescription found" which would indicate a problem with the file being opened? |
Note the last commits here were executed as per https://ci.openmicroscopy.org/job/OME-FILES-performance-win/119/ and on |
|
||
# JACE tests | ||
cd $BF_JACE_HOME | ||
/install/bin/metadata-performance-jace 10 /data/BBBC/NIRHTa-001.ome.tiff /data/out/bbbc-jace.ome.xml /data/results/bbbc-metadata-linux-jace.tsv | ||
/install/bin/metadata-performance-jace 10 /data/mitocheck/00001_01.ome.tiff /data/out/mitocheck-jace.ome.xml /data/results/mitocheck-metadata-linux-jace.tsv | ||
# Throws boost: mutex exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just run this with || true
to avoid the abort? We then get the statistics out of it--the error is only at program termination, not when running the tests.
This all looks fine, just one comment about the jace metadata test. |
This all looks good, thanks. |
Adds the OME-TIFF tubhiswt fileset to the performance datasets to be benchmarked.