Insight import location

[scottlittlewood]

Extract the location dialog and improve the UI & code base. Make Project / Screen selection more obvious.

[scottlittlewood]

Ready for some testing, check that functionality hasn't been broken / changed.

[jburel]

@scottlittlewood;

• Group selection box takes a lot of space. The layout should be reviewed.
• After switching to another group, I could not add the image.

[scottlittlewood]

@jburel Testing the switching of users has highlighted that the event fired is not consumed by the importer code and so the groups are out of synch.

[scottlittlewood]

When running as standalone the view and model are discarded and the Importer UI disappears

[scottlittlewood]

The ImporterComponent is discarding the view and model and is not being created again so the UI is not showing.

[scottlittlewood]

@jburel The lastest commits should resolve the issues regarding switching users in Importer standalone and embedded in Insight modes

[jburel]

@scottlittlewood: last commit

+import org.openmicroscopy.shoola.agents.treeviewer.TreeViewerAgent;
Should be replaced by the ImporterAgent

[jburel]

@scottlittlewood:

setInputsEnabled(false);
EditorDialog editor = new EditorDialog(owner,
newDataObject, false);
editor.addPropertyChangeListener(this);
editor.setModal(true);
UIUtilities.centerAndShow(editor);

                setInputsEnabled(true);

Modify the flag of the controls is not necessary. The problem is when you switch between group that when the change should happen.

[jburel]

@scottlittlewood: PR opened to fix the previous comment.

[jburel]

@scottlittlewood: The rest looks good. Standalone works as expected. Just the minor change mentioned in previous comment.

[scottlittlewood]

@jburel Resolved the state checking of the model following your advice. Cleaned up the imports too as I noticed one was unused.

[jburel]

@scottlittlewood: I found the following error

java.lang.Exception: Abnormal termination due to an uncaught exception.
java.lang.NullPointerException
    at java.util.Hashtable.get(Hashtable.java:334)
    at org.openmicroscopy.shoola.agents.fsimporter.chooser.LocationDialog.populateLocationComboBoxes(LocationDialog.java:1144)

To reproduce:

• Log in as user 1
• open importer
• switch user. Select user 2
• Open the importer. Play with Location selection. Close it
• Go to datamanager
• Right click on dataset and click import. The error happens.

[scottlittlewood]

@jburel I think this only occurs when attempting to directly import in to a Project, not a dataset. The Type check error commit above should fix this as I was able to recreate the issue by reverting the code and attempting to import in to a project.

[jburel]

@scottlittlewood: selecting a project is a case that we should handle since we can import folder directly as dataset.

[jburel]

@scottlittlewood: the remaining issues have been fixed. ready to go.

[joshmoore]

Just as a summary, I thought I'd add a screenshot of the new version. Few minor comments, but assume those can happen elsewhere.

[jburel]

@joshmoore, @scottlittlewood: Yes few things to be done but they will happen in another PR. Fixed some major usability issues (especially when using to import p/d/i and screens)