Omero home web settings 11373

[will-moore]

This removes the use of os.environ.get('OMERO_HOME') from omeroweb/settings.py. This means you can run OMERO web in production OR development locations without setting OMERO_HOME.

To test (need dist/lib/python on your $PYTHONPATH):

# run from production
$ bin/omero web start

Check that web is working OK, E.g. logging & static files etc

# run from development (remove dist libs)
$ rm -rf dist/lib/python/omeroweb
$ cd components/tools/OmeroWeb/omeroweb
$ python manage.py runserver

Again, check that web is working OK, E.g. logging & static files etc

[chris-allan]

The reason OMERO_HOME was used in the first place was actually to ensure that it behaved like other bin/omero commands. The intention was definitely not to further muddy the waters as to the usage of OMERO_HOME, in fact much the opposite. The changes in this pull request have many implications including potential issues with reading settings from etc/grid/config.xml, modification of log file directories, etc. It also breaks other directory structures of which we use extensively at @glencoesoftware.

I would think the simple solution to this problem, reading the description on ticket 11373 is to change the documentation back to OMERO_HOME. If we want to make this easier, fine but not on dev_4_4.

/cc @joshmoore, @cneves

[atarkowska]

There is still one place where OMERO_HOME is used see https://github.com/will-moore/openmicroscopy/blob/OMERO_HOME_web_settings_11373/components/tools/OmeroWeb/omeroweb/webstart/views.py#L54 as it rise an error 'Settings' object has no attribute 'OMERO_HOME'. Is always worth to search for phrase across the entire codebase.

[will-moore]

@chris-allan @joshmoore @aleksandra-tarkowska OK, so maybe we just tell users who want to run web from a non-standard location (E.g. from components/tools/OmeroWeb/omeroweb/) to set $OMERO_HOME. This is a small number of people, and will generally be on non-production servers anyway.

[chris-allan]

That makes sense @will-moore. If you want to add something about absolutely not running production servers this way that's totally understandable.