New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #10209: restrict one's changes to user, group #1723
fix #10209: restrict one's changes to user, group #1723
Conversation
This works fine, the trouble is that in #565 system users were prevented from removal from the group on webadmin/experimenter/edit page but I can still easily to click X on webadmin/group/edit page. Does it make sense if I fix webadmin and merge with this PR?
|
please merge mtbc#7 |
maybe someone else could look at this as well |
@aleksandra-tarkowska : No one else can merge 7 other than @mtbc. Would you like to close it and open a full PR? |
ok doing that |
moved to #1733 |
I also tested via the DEV6 --> 5.0 script while looking at ticket 10703. 👍 |
…ictions fix #10209: restrict one's changes to user, group
To test, work with SQL to make sure that you cannot rename the
root
,guest
users, nor thesystem
,user
,guest
groups, nor can you remove theroot
user from thesystem
oruser
groups. Also test that other changes on those tables -- updates, deletes -- remain permitted.Also, given #1595, check that http://hudson.openmicroscopy.org.uk/job/OmeroJava-integration-develop/lastCompletedBuild/testngreports/integration/integration.AdminServiceTest/ continues to pass.
Fixes https://trac.openmicroscopy.org.uk/ome/ticket/10209.
--no-rebase