Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10209: restrict one's changes to user, group #1723

Merged

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented Nov 6, 2013

To test, work with SQL to make sure that you cannot rename the root, guest users, nor the system, user, guest groups, nor can you remove the root user from the system or user groups. Also test that other changes on those tables -- updates, deletes -- remain permitted.

Also, given #1595, check that http://hudson.openmicroscopy.org.uk/job/OmeroJava-integration-develop/lastCompletedBuild/testngreports/integration/integration.AdminServiceTest/ continues to pass.

Fixes https://trac.openmicroscopy.org.uk/ome/ticket/10209.

--no-rebase

@atarkowska
Copy link
Member

This works fine, the trouble is that in #565 system users were prevented from removal from the group on webadmin/experimenter/edit page but I can still easily to click X on webadmin/group/edit page. Does it make sense if I fix webadmin and merge with this PR?

ValidationException at /webadmin/group/save/0/

exception ::omero::ValidationException
{
    serverStackTrace = ome.conditions.ValidationException: experimenter 'root' may not be removed from the 'system' or 'user' group
    at ome.logic.AdminImpl.removeGroups(AdminImpl.java:710)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

@atarkowska
Copy link
Member

firefoxscreensnapz001

@atarkowska
Copy link
Member

please merge mtbc#7

@atarkowska
Copy link
Member

maybe someone else could look at this as well

@joshmoore
Copy link
Member

@aleksandra-tarkowska : No one else can merge 7 other than @mtbc. Would you like to close it and open a full PR?

@atarkowska
Copy link
Member

ok doing that

@atarkowska
Copy link
Member

moved to #1733

@joshmoore
Copy link
Member

I also tested via the DEV6 --> 5.0 script while looking at ticket 10703. 👍

joshmoore added a commit that referenced this pull request Nov 7, 2013
…ictions

fix #10209: restrict one's changes to user, group
@joshmoore joshmoore merged commit 9b3ab0d into ome:develop Nov 7, 2013
@mtbc mtbc deleted the trac-11465-user-group-change-restrictions branch November 19, 2013 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants