Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the code-signing script from the target dir #2241

Merged
merged 2 commits into from Apr 3, 2014

Conversation

manics
Copy link
Member

@manics manics commented Apr 1, 2014

Fix a build problem introduced in #2193. Enter target/ before running the code-signing script, so that temporary and log files will be removed by ./build.py clean. Also disable webstart signing in the update-version target.

Testing: check webstart works, check gretzky webstart is self-signed, check RELEASE builds aren't signed. Also look out for any instances of unwanted signing if you want, I've got a verification summary script at https://github.com/manics/certificate-generation/blob/master/omero/verify_jars.py

This is so that ./build.py clean will remove any logs or temporary directories
@manics manics mentioned this pull request Apr 1, 2014
@manics
Copy link
Member Author

manics commented Apr 1, 2014

--rebased-to #2238

@manics manics changed the title Run the code-signing from the target dir Run the code-signing script from the target dir Apr 1, 2014
@jburel jburel added the dev_5_0 label Apr 1, 2014
@manics
Copy link
Member Author

manics commented Apr 2, 2014

One more pending change suggested by @kennethgillen ... check system proxy env vars and convert them to whatever Java wants when timestamping.

@joshmoore
Copy link
Member

From http://ci.openmicroscopy.org/job/OMERO-5.0-merge-ice33/203/consoleFull

++ '[' -z '' ']'
++ pushd target
/opt/hudson/workspace/OMERO-5.0-merge-ice33/src/target /opt/hudson/workspace/OMERO-5.0-merge-ice33/src
++ ../docs/hudson/omero_insight_sign.py ../lib/keystore omedev OMERO.server-5.0.1-rc1-155-d1d79c1-ice33-b203.zip -kp omedev -cp omedev -ts no -oz OMERO.server-5.0.1-rc1-155-d1d79c1-ice33-b203.zip
2014-04-03 06:15:16 Unzipping OMERO.server-5.0.1-rc1-155-d1d79c1-ice33-b203.zip
2014-04-03 06:15:22 Signing OMERO.server-5.0.1-rc1-155-d1d79c1-ice33-b203/lib/insight/specification.jar
2014-04-03 06:15:24 Signed OMERO.server-5.0.1-rc1-155-d1d79c1-ice33-b203/lib/insight/specification.jar
...
2014-04-03 06:17:23 Renaming OMERO.server-5.0.1-rc1-155-d1d79c1-ice33-b203.zip to OMERO.server-5.0.1-rc1-155-d1d79c1-ice33-b203.zip.bak
2014-04-03 06:17:23 Zipping OMERO.server-5.0.1-rc1-155-d1d79c1-ice33-b203.zip
2014-04-03 06:17:47 Creating OMERO.server-5.0.1-rc1-155-d1d79c1-ice33-b203.zip.md5
++ popd

Certainly looks good. Will discuss with @kennethgillen, but likely this will need to be merged for testing with 5.0.1

joshmoore added a commit that referenced this pull request Apr 3, 2014
Run the code-signing script from the target dir
@joshmoore joshmoore merged commit e60d82b into ome:dev_5_0 Apr 3, 2014
@manics manics deleted the more_webstart_codesigning_tweaks branch April 8, 2014 09:15
@manics
Copy link
Member Author

manics commented Apr 16, 2014

--rebased-to #2321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants