6905 del ofile #310
Closed
6905 del ofile #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a good deal more complicated than would might have expected. In order to handle the group==-1 case, it was necessary to pass in the details to isGraphCritical. However, to be able to simultaneously check each of the different types of writes (ANNOTATE, EDIT, DELETE, LINK) it was necessary to re-work allowUpdateOrDelete to check multiple at the same time.
The call to getSession in the ctor of DetailsI was hanging since it was within an Ice thread which ic.destroy was waiting on. Other uses of getSession should not hang on destroy.
Work on 7314 is happening on the chgrp branch, because it adds a new requirement to how we work with graphs. Before, it was never possible to walk "up" a graph, which is needed for handling file to file-annotation issues.
Failing tests were disabled and a few minor shifts in logic were corrected for. By large, however, this looks to bring us back to where we were previously.
Ctors of the measurement contexts now call get_thread_pool, which will instantiate the global "thread_pool" if it is None.
This is useful for immediately deleting or downloading the stdout and stderr files (i.e. during testing)
This uses the same technique as the fileannotation delete (#7314) to delete the joboriginalfilelink if a file is linked to a job.
Deletion instances are now provided by the Spring context with the name "ome.services.delete.Deletion". There is still work that could be done to make the use of the object easier (start/execute/deleteFiles/stop). Also enabled the "script delete" command for the CLI.
|
Using sprint3-bugs gh-292 since it relies on commits from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://trac.openmicroscopy.org.uk/ome/ticket/6905
This commit allows deleting original files that are linked to jobs. I've always avoided allowing this, but it's necessary to allow deleting scripts. To test you can do:
or even:
This will require some discussion. One way we could prevent the deletion of stdout and stderr (if we wanted to) would be to require:
or similar.